Migrate PR review plugin to extensions repository#2324
Migrate PR review plugin to extensions repository#2324juanmichelini wants to merge 15 commits intomainfrom
Conversation
- Delete agent_script.py and prompt.py (now in extensions repo) - Update action.yml to load scripts from OpenHands/extensions - Change sdk-repo/sdk-version inputs to extensions-repo/extensions-version - Update README and workflow.yml to reflect new structure - Install openhands-sdk and openhands-tools from PyPI Related to #2282 Co-authored-by: openhands <openhands@all-hands.dev>
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
REST API breakage checks (OpenAPI) — ❌ FAILEDResult: ❌ FAILED
Log excerpt (first 1000 characters) |
|
@OpenHands actually we already have https://github.com/OpenHands/software-agent-sdk/blob/main/.github/workflows/pr-review-by-openhands.yml so let's remove .github/actions/pr-review/action.yml and instead make the example refer to .github/workflows/pr-review-by-openhands.yml |
|
I'm on it! juanmichelini can track my progress at all-hands.dev |
|
I have completed the migration of the PR review logic from a composite action to direct workflow steps, as requested. Summary of Changes:
The changes have been pushed to the |
|
@OpenHands that's better, but notice that ./03_github_workflows/02_pr_review/evaluate_review.py also lives in the extension repo now see https://github.com/OpenHands/extensions/tree/main/plugins/pr-review/workflows |
|
I'm on it! juanmichelini can track my progress at all-hands.dev |
|
I have completed the requested changes to migrate Changes Implemented:
The changes have been pushed to the |
|
I have aligned the workflows with the repository structure as requested. Updates:
|
Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
This PR migrates the PR review plugin scripts from the SDK repository to the extensions repository, addressing issue #2282.
Changes
Deleted Files
examples/03_github_workflows/02_pr_review/agent_script.py- Now lives in extensions repoexamples/03_github_workflows/02_pr_review/prompt.py- Now lives in extensions repoexamples/03_github_workflows/02_pr_review/evaluate_review.py- Now lives in extensions repo.github/actions/pr-review/action.yml- Now lives in extensions repoexamples/03_github_workflows/02_pr_review/action.yml- Removed symlinkUpdated Files
OpenHands/extensions/plugins/pr-reviewcomposite action, aligning with theOpenHands/benchmarksrepository structure.OpenHands/benchmarksrepository structure.Benefits
✅ Eliminates duplicate maintenance of PR review scripts across two repositories
✅ Simplifies workflow configuration by using a shared composite action
✅ Aligns workflow structure with
OpenHands/benchmarksbest practices✅ Cleaner separation of concerns - SDK for framework, extensions for plugins
Related Issues
Closes #2282
Testing
The updated workflows now:
OpenHands/extensions/plugins/pr-review@mainto perform reviewsextensions/plugins/pr-review/scripts/evaluate_review.pyfor evaluationUsers can continue using the workflow by referencing the composite action as shown in the updated example.
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:abfc43f-pythonRun
All tags pushed for this build
About Multi-Architecture Support
abfc43f-python) is a multi-arch manifest supporting both amd64 and arm64abfc43f-python-amd64) are also available if needed