Rot Elimination Plans: Systematic Codebase Cleanup

[trissim]

Rot Elimination Plans: Systematic Codebase Cleanup

Overview

9 plans to eliminate ~3500 lines of rot. No wrappers. No backwards compatibility.

Dependency Graph

┌─────────────────────────────────────────────────────────────┐
│  INDEPENDENT (Wave 1 - Can Start Immediately)               │
│  ┌──────────────┐ ┌──────────────┐ ┌──────────────┐         │
│  │ psygnal      │ │ styling      │ │ config       │         │
│  │ migration    │ │ centralized  │ │ merging      │         │
│  │ (~120 lines) │ │ (~200 lines) │ │ (~90 lines)  │         │
│  └──────────────┘ └──────────────┘ └──────────────┘         │
│  ┌──────────────┐ ┌──────────────┐                          │
│  │ python       │ │ dimension    │                          │
│  │ serializer   │ │ abstraction  │                          │
│  │ (~950 lines) │ │ (~400 lines) │                          │
│  └──────────────┘ └──────────────┘                          │
└─────────────────────────────────────────────────────────────┘

┌─────────────────────────────────────────────────────────────┐
│  STREAMING (Wave 2 - Sequential)                            │
│  ┌──────────────┐     ┌──────────────┐                      │
│  │ backend      │ ──► │ message      │                      │
│  │ unification  │     │ protocol     │                      │
│  │ (~300 lines) │     │ (~100 lines) │                      │
│  └──────────────┘     └──────────────┘                      │
└─────────────────────────────────────────────────────────────┘

┌─────────────────────────────────────────────────────────────┐
│  COMPILER (Wave 3 - Sequential, Highest Risk)               │
│  ┌──────────────┐     ┌──────────────┐                      │
│  │ generic      │ ──► │ step         │                      │
│  │ compiler     │     │ executor     │                      │
│  │ spec         │     │ extraction   │                      │
│  │ (~200 lines) │     │ (~647 lines) │                      │
│  └──────────────┘     └──────────────┘                      │
└─────────────────────────────────────────────────────────────┘

Plan Summaries

Plan	What It Does	Lines Saved
plan_01_psygnal_migration	Replace 8 callback lists with psygnal Signals	~120
plan_01_centralized_styling	Move 227 setStyleSheet calls to app-level stylesheet	~200
plan_01_eliminate_config_merging	Delete 90 lines that duplicate config framework	~90
plan_01_python_source_serializer	Replace 950-line pickle_to_python with type-dispatched formatters	~950
plan_03_dimension_abstraction	Replace 103 channel/slice/frame references with HyperstackDimensions	~400
plan_01_streaming_backend_unification	Merge Napari/Fiji backends into one ABC	~300
plan_02_streaming_message_protocol	Replace stringly-typed JSON with typed dataclasses	~100
plan_01_generic_compiler_spec	Replace Dict[str, Any] plans with typed frozen StepPlan	~200
plan_02_step_executor_extraction	Move 647-line process() to dedicated StepExecutor	~647

Key Principles

1. No wrappers — Delete old code, update callers, fail loud
2. No backwards compatibility — If something breaks, fix it properly
3. DECLARATION → INTROSPECTION → DERIVATION — Implementations declare, ABCs derive
4. Typed over stringly-typed — Frozen dataclasses over Dict[str, Any]

Testing Strategy

• Each plan must pass existing tests before merge
• Manual smoke test after each plan
• Full integration test after all plans merge

Files

• plans/rot_elimination/00_MASTER_PLAN.md — Dependency graph, execution order, testing strategy
• plans/rot_elimination/plan_*.md — Individual plans with cleanup sections

[continue]

Learn more

---

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts