Skip to content

Simplify clippy CI job to use cargo directly#87

Merged
jerrysxie merged 1 commit intoOpenDevicePartnership:mainfrom
jerrysxie:update-clippy-job
Feb 27, 2026
Merged

Simplify clippy CI job to use cargo directly#87
jerrysxie merged 1 commit intoOpenDevicePartnership:mainfrom
jerrysxie:update-clippy-job

Conversation

@jerrysxie
Copy link
Contributor

Replace the giraffate/clippy-action GitHub Action with a direct cargo clippy invocation. This removes the dependency on a third-party action and its associated configuration (reporter, clippy_flags, github_token).

Closes #85

Replace the giraffate/clippy-action GitHub Action with a direct
`cargo clippy` invocation. This removes the dependency on a
third-party action and its associated configuration (reporter,
clippy_flags, github_token).
@jerrysxie jerrysxie self-assigned this Feb 25, 2026
Copilot AI review requested due to automatic review settings February 25, 2026 23:46
@jerrysxie jerrysxie requested a review from a team as a code owner February 25, 2026 23:46
@jerrysxie jerrysxie added the enhancement New feature or request label Feb 25, 2026
@jerrysxie jerrysxie requested review from asasine and gjpmsft February 25, 2026 23:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the clippy CI job by replacing the third-party giraffate/clippy-action GitHub Action with a direct cargo clippy command invocation. This addresses issue #85 which reported problems with the clippy-action and reduces dependency on external actions. The clippy lint configuration itself is preserved through the [lints.clippy] section in Cargo.toml, which defines the required lint levels.

Changes:

  • Removed the giraffate/clippy-action@v1 GitHub Action and its configuration (reporter, clippy_flags, github_token)
  • Replaced with direct cargo clippy command execution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jerrysxie jerrysxie merged commit 6afe0e5 into OpenDevicePartnership:main Feb 27, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

tps6699x: Update clippy CI workflow

4 participants