Add additional USB control methods to DpConfig and TbtConfig#86
Merged
gjpmsft merged 3 commits intoOpenDevicePartnership:mainfrom Feb 24, 2026
Merged
Add additional USB control methods to DpConfig and TbtConfig#86gjpmsft merged 3 commits intoOpenDevicePartnership:mainfrom
DpConfig and TbtConfig#86gjpmsft merged 3 commits intoOpenDevicePartnership:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds USB data-path support controls to the generated DP and TBT configuration register field-sets, and exposes an async helper to modify TBT config in-place (mirroring existing DP config support).
Changes:
- Add
UsbDataPathbitfield + conversion enums toDpConfigandTbtConfigindevice.yaml. - Add
modify_tbt_config()async helper toTps6699xinternal async API (parallelsmodify_dp_config).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/asynchronous/internal/mod.rs | Adds modify_tbt_config() for async read-modify-write of the TbtConfig register. |
| device.yaml | Extends DpConfig and TbtConfig register definitions with UsbDataPath fields and value conversions for codegen. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@OpenDevicePartnership/crate-auditors the |
gjpmsft
approved these changes
Feb 24, 2026
RobertZ2011
approved these changes
Feb 24, 2026
Contributor
|
You'll need to add an exception for bincode, see https://github.com/OpenDevicePartnership/embedded-services/blob/fcb2be314c177f166ef93eaa49e50729ddf2f19e/deny.toml#L80 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for USB data path configuration to both
DpConfigandTbtConfigindevice.yaml, and introduces a new asynchronous method for modifying TBT configuration settings in the internal module. These changes enhance configurability and flexibility for USB and Thunderbolt features.Enhancements to configuration support:
UsbDataPathfield toDpConfigindevice.yaml, enabling USB data path support with conversion values for requirement status.UsbDataPathfield toTbtConfigindevice.yaml, also with conversion values for requirement status.API improvements:
modify_tbt_configasynchronous method to theTps6699ximplementation insrc/asynchronous/internal/mod.rs, allowing flexible modification of TBT configuration settings.