Small fixes and refactors#930
Merged
robertbaldyga merged 9 commits intoOpen-CAS:masterfrom Feb 26, 2026
Merged
Conversation
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
The existing OCF_DIV_ROUND_UP() consists of expressions that can't be used to define size of static array. Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Silence compiler warnings. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
The req->error does no longer convey error codes from lower layers. This field is in a full control of the request owner, so the queue should not modify it's value, to avoid tricky bugs. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Initialize req->core in ocf_req_new() so that there is no need to set it manually. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Separate iterator advance from getting current LRU list index: - The iterator goes over elements, not only lists, so returning a list number is rather a weird artifact than obvious behavior. - It makes the code more readable in the places, where only iter advance is needed, without getting a list index. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.