SaiKrishna - Editable And Selectable Fields In Equipment#4857
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Sai Krishna,
I have reviewed your PR locally and even though the functionality works as per requirement. There are few UI issues which you can find in the below screenshots.
As you can see even though the application is in light mode, the editable feature is in dark mode

As you can see when the application is in dark mode, the dropdown options are in double


There was a problem hiding this comment.
Hi Sai Krishna,
The core functionalities are working as expected. The editable fields, dropdowns, and save integration are functioning correctly.
However, there is a UI issue in dark mode. When the page is in dark mode and Edit is clicked, the edit view switches to light mode, so the UI is not consistent with the selected theme.
Requesting changes to ensure UI consistency in dark mode.
UI Inconsistencies in Dark Mode:
|
|
@Anusha-Gali @HemanthNidamanuru Dark mode issue is fixed, please review |
|
Thank you all, merging! |










Related PRS (if any):
This frontend PR is related to the 2054backend PR.
…
Main changes explained:
Update src/constants/bmdashboard/equipmentConstants.js for adding UPDATE_EQUIPMENT_START, SUCCESS and ERROR action types
Update src/actions/bmdashboard/equipmentActions.js for adding updateEquipmentById action with PUT request and toast notifications
Update src/reducers/bmdashboard/equipmentReducer.js for handling update loading/success/error states in Redux store
Update src/components/BMDashboard/Equipment/Detail/EquipmentDetail.jsx for converting static fields into editable dropdowns/radio buttons with edit mode toggle, form validation, Save/Cancel buttons and reading equipmentClass from both top-level and legacy nested paths
Update src/components/BMDashboard/Equipment/Detail/EquipmentDetailPage.module.css for styling editable section, dropdowns, radio groups, action buttons and dark mode support
Update src/components/BMDashboard/Equipment/List/EquipmentsTable.jsx for adding fallback text to equipment name link so it's always visible and clickable
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
editableAndSelectableFieldsInEquipment.mp4