Conversation
added 5 commits
July 11, 2022 20:22
Ocramius
requested changes
Jul 11, 2022
Ocramius
reviewed
Jul 11, 2022
|
Anything that needs to be done in order to get this merged & released? Happy to help if something is missing. |
Owner
|
Release requires this work: https://github.com/Ocramius/ProxyManager/milestone/56 |
Author
|
The problem with this PR is that the tests won't work with locked dependencies on both php 8.0 and 8.1. Not sure how to solve this without removing some tests. |
Owner
|
Supporting I can suggest skipping some tests on |
…with both 8.0 and 8.1.
|
Hi, any update on this? |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~8.0.0constraint to~8.02.3.9and PHP8.0.218.1to the github pipesFixes #721