Tiny bodge around Ztsd stream not supporting position#217
Open
cpmpal wants to merge 1 commit intoNorbyte:masterfrom
Open
Tiny bodge around Ztsd stream not supporting position#217cpmpal wants to merge 1 commit intoNorbyte:masterfrom
cpmpal wants to merge 1 commit intoNorbyte:masterfrom
Conversation
Wrapping around can seek so non-ztsd streams can still report position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
Please feel free to reject this but it seems with the new Ztsd compression there's no support for positions, but it also seems that the position value when using the steam is not really used since the other log is sound save for debug messages.
It's a one second fix but it seems to run okay to load save files locally on my machine with latest master
Also thanks for doing this work!