Skip to content

Conversation

@Dafyh
Copy link
Contributor

@Dafyh Dafyh commented May 24, 2025

@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.60%. Comparing base (28ee6a9) to head (03eb65d).
Report is 179 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##            master     #488       +/-   ##
============================================
- Coverage   100.00%   83.60%   -16.40%     
============================================
  Files           15       29       +14     
  Lines          649     1952     +1303     
  Branches         0        1        +1     
============================================
+ Hits           649     1632      +983     
- Misses           0      320      +320     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fraxken
Copy link
Member

fraxken commented May 24, 2025

Hmm not sure why but one test is failing on ubuntu

@Dafyh
Copy link
Contributor Author

Dafyh commented May 25, 2025

I've searched but I can't find it. Indeed on ubuntu, the mock doesn't work inside the 'open' package ¯\(ツ)/¯.
The only way I've found is to put 'open' in an exported object 😑.

@fraxken fraxken merged commit 31d1bb7 into NodeSecure:master May 26, 2025
10 of 11 checks passed
@fraxken
Copy link
Member

fraxken commented May 26, 2025

@allcontributors please add @Dafyh for test

@allcontributors
Copy link
Contributor

@fraxken

I've put up a pull request to add @Dafyh! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants