Feature/cstackex 88 - Storage Pool operation code changes and UTs#30
Merged
piyush5netapp merged 2 commits intomainfrom Feb 6, 2026
Merged
Feature/cstackex 88 - Storage Pool operation code changes and UTs#30piyush5netapp merged 2 commits intomainfrom
piyush5netapp merged 2 commits intomainfrom
Conversation
rajiv-jain-netapp
approved these changes
Feb 5, 2026
| public AccessGroup getAccessGroup(AccessGroup accessGroup) { | ||
| //TODO | ||
| return null; | ||
| s_logger.info("getAccessGroup: Get export policy"); |
There was a problem hiding this comment.
Could you clarify why these code changes were included as part of the unit test task? Was there a pending merge that necessitated this update?
Author
There was a problem hiding this comment.
These were added as needed for fail-safe check later point of time for already existing accessGroup for NFS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?