Skip to content

Conversation

@romintomasetti
Copy link
Contributor

@romintomasetti romintomasetti commented Jan 25, 2026

This was working 2 days ago.

I'll try to find the culprit commit later today.

It seems it stopped working with:

The compile error looks like:

[  0%] Building CXX object test/exec/CMakeFiles/test.exec.dir/test_fork.cpp.o
In file included from /workspaces/stdexec/test/exec/test_fork.cpp:17:
In file included from /workspaces/stdexec/include/exec/fork_join.hpp:18:
/workspaces/stdexec/include/exec/../stdexec/__detail/__receiver_ref.hpp:55:9: error: 
      static assertion failed: get_env() must return the same type as env_of_t<_Rcvr>
   55 |         __same_as<_Env, env_of_t<_Rcvr>>, "get_env() must return the same type as env_of_t<_Rcvr>");
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/workspaces/stdexec/include/exec/../stdexec/__detail/__env.hpp:318:31: note: in
      instantiation of member function
      'std::execution::__rcvr_ref<exec::fork_join_t::_opstate_t<std::execution::(anonymous
      namespace)::__sexpr<std::execution::(lambda at
      /workspaces/stdexec/include/exec/../stdexec/__detail/__basic_sender.hpp:59:53){}>,
      std::execution::__tup::__tuple<std::execution::__clsur::__closure<std::execution::__then::then_t,
      (lambda at /workspaces/stdexec/test/exec/test_fork.cpp:79:35)>,
      std::execution::__clsur::__closure<std::execution::__then::then_t, (lambda at
      /workspaces/stdexec/test/exec/test_fork.cpp:80:35)>>,
      std::execution::__sync_wait::__receiver<>::__t>,
      std::execution::__env::__fwd<std::execution::__sync_wait::__env>::__t>::get_env' requested here
  318 |         return __env_provider.get_env();

I'm not sure if the fix I'm doing is the right thing to do.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 25, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericniebler
Copy link
Collaborator

/ok to test 3bbf3fe

@ericniebler
Copy link
Collaborator

i think #1789 will fix this issue.

@romintomasetti
Copy link
Contributor Author

@ericniebler Indeed, it will fix it. I'll rebase this one when #1789 is merged.

Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
@ericniebler
Copy link
Collaborator

/ok to test a408b96

@romintomasetti
Copy link
Contributor Author

@ericniebler The job that failed that not provide much log...

@ericniebler ericniebler merged commit 5b0f1b1 into NVIDIA:main Jan 26, 2026
36 of 37 checks passed
@romintomasetti romintomasetti deleted the fork-join-bug branch January 26, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants