-
Notifications
You must be signed in to change notification settings - Fork 575
Ensure datapipes is checked for optional imports too. #1390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
handling of partial matches.
Co-authored-by: Peter Sharpe <peterdsharpe@gmail.com>
…name and the distribution name
Greptile OverviewGreptile SummaryMigrated all datapipes module imports to use Key changes:
Packages migrated to OptionalImport:
The changes ensure consistent error messages with install hints across the codebase and defer imports until actual usage. Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, no comments
Raise ImportError instead of RuntimeError - it just is deferred to runtime. Clean up TE usage in MLP. Fix the way OptionalImport was handling dunders.
|
/blossom-ci |
Stack generated by Git Town