change image load from 3ch to 1ch#56
Closed
dhpollack wants to merge 1 commit intoNVIDIA:masterfrom
dhpollack:fix_mask_load
Closed
change image load from 3ch to 1ch#56dhpollack wants to merge 1 commit intoNVIDIA:masterfrom dhpollack:fix_mask_load
dhpollack wants to merge 1 commit intoNVIDIA:masterfrom
dhpollack:fix_mask_load
Conversation
Contributor
|
Good work but I think this is a duplicate of #33. |
Author
|
Kind of. But he assumes the image is a 32 bit encoding and I'm assuming it's 8 bit (which is more typical in ML). |
Author
Author
|
gonna close, reopen if you want to add it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #55. One expects a 1 channel mask (resize based only on height and width) but you force this to become a 3 channel mask upon loading (mode="RGB"). Now we correctly get a 1 channel 8 bit mask.