Removed a literal comparison pitfall from the code#109
Open
NaelsonDouglas wants to merge 1 commit intoNVIDIA:masterfrom
Open
Removed a literal comparison pitfall from the code#109NaelsonDouglas wants to merge 1 commit intoNVIDIA:masterfrom
NaelsonDouglas wants to merge 1 commit intoNVIDIA:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
The code was comparing booleans using the operator '==', where in Python the indicated is to use the operator 'is', otherwise we would fall into a literal comparison pitfall. This pitfall was detected using Pylint and generated the following message error code and message:
Pylint code: C0121
Comparison 'styl_seg.size == False' should be 'styl_seg.size is False' if checking for the singleton value False, or 'not styl_seg.size' if testing for falsiness
Solution
Removed the '==' operator and changed it to 'is'