Conversation
|
@danielbeach - I am getting this error: I'm not sure the current code works. |
@MrPowers Your PR looks different from the original code that's been merged. Your PR adds things like The current code is unit-tested and appears to work, do you think the unit test is inaccurate? |
|
@danielbeach - I don't think the current code tests |
Co-authored-by: Daniel Beach <danielbeach@Daniels-MacBook-Pro.local>
|
@MrPowers I think the unit test was failing from another test failure, not the one concerned in this PR. I re-ran the tests locally and they passed, and re-ran the tests on this PR and they passed. |
|
@danielbeach - thanks for the ping. I think you already fixed this, so closing this PR. Thanks! |
No description provided.