Unit test over multiple python versions#118
Open
ianwesleyarmstrong wants to merge 14 commits intoMrPowers:mainfrom
Open
Unit test over multiple python versions#118ianwesleyarmstrong wants to merge 14 commits intoMrPowers:mainfrom
ianwesleyarmstrong wants to merge 14 commits intoMrPowers:mainfrom
Conversation
Author
|
I've been running the tests on my fork and it appears that python 3.11 may cause some problems - I'll remove that for the time being. https://github.com/ianwesleyarmstrong/mack/actions/runs/5652132175 |
Owner
|
How does this deal with the Delta Lake / PySpark versions that are incompatible? I don't think mack supports Delta 1.0. Here are the version combinations I think we should run (Delta Lake version | PySpark version): 2.4.x | 3.4.x This comes from the docs. |
Author
jaceklaskowski
approved these changes
Nov 1, 2023
jaceklaskowski
left a comment
There was a problem hiding this comment.
LGTM (and just learnt that mack uses poetry 👏👏👏 )
|
Hi @MrPowers, Is there any updates on this branch? I'm looking forward to using mack on pyspark 3.4.1 and delta-spark 2.4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started with the currently supported python versions and any minor versions of delta lake > 1.0 - I'm happy to adjust these as needed. I thought it also might be worthwhile to test over different versions of
pyspark, so I included the minor versions > 3 as well: