Skip to content

Conversation

@netmindz
Copy link
Collaborator

@netmindz netmindz commented Jan 28, 2026

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configurations for improved naming consistency and job dependency management.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'review', 'context'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
📝 Walkthrough

Walkthrough

The PR updates GitHub Actions workflow configurations by renaming the build workflow from "PlatformIO CI" to "build-template" and synchronizing the corresponding job identifier and its dependency references across workflow files.

Changes

Cohort / File(s) Summary
Workflow Configuration Updates
.github/workflows/build.yml
Renamed workflow from "PlatformIO CI" to "build-template"
Job Identifier & Dependency Sync
.github/workflows/nightly.yml
Updated job identifier from wled_build to build and adjusted dependency reference from needs: wled_build to needs: build

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Matrix builds #117: Main PR that renames the build workflow job from wled_build to build and updates nightly job dependencies, directly modifying the same workflow identifiers.
  • Nightly builds #115: Related PR that also modifies GitHub Actions workflow files with build workflow name and job identifier changes, implementing consistent naming conventions.

Poem

🐰 A workflow renamed with care,
From PlatformIO to build-template fair,
Dependencies linked, all in sync,
No broken chains, not even a kink! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix naming' is vague and generic, using a non-descriptive term that doesn't convey what naming was actually fixed or why. Provide a more specific title that describes the actual naming changes, such as 'Rename workflow jobs for consistency' or 'Fix job naming in CI workflows'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ewowi
Copy link
Collaborator

ewowi commented Jan 29, 2026

MoonLight has the system update module, see https://moonmodules.org/MoonLight/system/update/

With the new nightly build I got this:

Screenshot 2026-01-29 at 08 59 42

So or the tag, or the description needs to start with v0.8.1.something e.g. v0.8.1.nightly ...
v0.8.1 can come from -D APP_VERSION

I will experiment with what works and report back here

@ewowi
Copy link
Collaborator

ewowi commented Jan 29, 2026

Update: the tag must be exactly have this format v0.8.1:

Screenshot 2026-01-29 at 09 09 22

I added v0.8.1 in the release name as you can see in above screenshot.

Propose to shorten it to 'nightly 20260128'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants