-
-
Notifications
You must be signed in to change notification settings - Fork 0
🎨 Palette: accessibility and UX improvements to README.md #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Moohan <5982260+Moohan@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refines Markdown link and tooltip usage in the README to improve accessibility and UX, ensuring tooltips describe link destinations, deprecated status is explicit, and image links point to the expected user profile, while documenting the learning in the palette notes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughUpdates documentation and README to standardise tooltip placement on anchor elements rather than image elements when displaying linked images, alongside updating badge links to point to GitHub profile pages and adding deprecation notices. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Consider moving the '(deprecated)' text outside the strikethrough (e.g.,
~~phssensitivitylabels~~ (deprecated)) so that the deprecated status remains visually and semantically clear, especially for assistive technologies that may handle struck-through text differently. - Some of the new link titles repeat visible link text almost verbatim; you might simplify or tailor them (e.g., adding brief context like 'Open skillicons.dev in a new tab') to provide additional value beyond what is already on screen.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider moving the '(deprecated)' text outside the strikethrough (e.g., `~~phssensitivitylabels~~ (deprecated)`) so that the deprecated status remains visually and semantically clear, especially for assistive technologies that may handle struck-through text differently.
- Some of the new link titles repeat visible link text almost verbatim; you might simplify or tailor them (e.g., adding brief context like 'Open skillicons.dev in a new tab') to provide additional value beyond what is already on screen.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
💡 What:
phssensitivitylabelslink.🎯 Why:
📸 Before/After:
♿ Accessibility:
PR created automatically by Jules for task 6197350914072018308 started by @Moohan
Summary by Sourcery
Improve README and internal documentation for clearer, more accessible link tooltips and profile navigation.
Enhancements:
phssensitivitylabelsproject is deprecated in the projects list.Summary by CodeRabbit
Documentation