Switch to defusedxml for secure XML parsing in skills and evaluation harness #55
+7
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses the standard
xml.etree.ElementTreeto parse XML files from untrusted sources, such as Office documents (OOXML) processed by skills and user-provided evaluation files. This poses a potential risk for XML External Entity (XXE) attacks.I noticed these vulnerable patterns while reviewing the codebase and decided to switch to
defusedxml, which provides a secure drop-in replacement.Changes:
defusedxmlto project dependencies inpyproject.toml.mini_agent/skills/mcp-builder/scripts/evaluation.pyto usedefusedxml.etree.ElementTree.redlining.pyfor both DOCX and PPTX skills by replacing lazy imports with the secure alternative.These improvements ensure the agent can safely handle malformed or malicious XML documents without compromising the underlying system.