ForgeFlower Legacy; FG-2.2 Base#139
Open
TheCurle wants to merge 22 commits intoMinecraftForge:legacy-2.2from
Open
ForgeFlower Legacy; FG-2.2 Base#139TheCurle wants to merge 22 commits intoMinecraftForge:legacy-2.2from
TheCurle wants to merge 22 commits intoMinecraftForge:legacy-2.2from
Conversation
Collaborator
|
I think for ease of management it makes sense to keep this in the same repo, but having a different artifact ID is imo the easiest way to distinguish the versions for consumers. |
Thanks to Sciwhiz12
Thanks again to sciwhiz12.
* test: Add Comparison Test against FG2 Output Setup Required: #### testData/retrogradle/fg2/decompiled.zip - clone 1.11.x (FG2) from <a href="https://github.com/RetroGradle/MinecraftForge">RetroGradle/MinecraftForge</a> - `gradlew setup` (May need to be from the terminal due to gradle version) - copy `build/localCache/decompiled.zip` #### testData/retrogradle/fg3/output.jar - checkout retrogradle1.11 branch - `gradlew setup` (May require a second `gradlew setup` as the first downloads the custom MCPConfig zip) - copy `projects/mcp/build/mcp/decompile/output.jar` Diffs are output to `testData/retrogradle/output` Signed-off-by: AterAnimAvis <AterAnimAvis@gmail.com>
The original patched will skip the IBytecodeProvider due to the always present byte array (even if it is 0 length), It looks like the original intention is for `link.data` to be null in this case. Signed-off-by: AterAnimAvis <AterAnimAvis@gmail.com>
Fixes the following decomp difference in BiomeMesa: <https://gist.github.com/AterAnimAvis/36edd447fde25c3ea9259bc20033d4cb> Signed-off-by: AterAnimAvis <AterAnimAvis@gmail.com>
Signed-off-by: AterAnimAvis <AterAnimAvis@gmail.com>
Author
|
I have adjusted this so that it publishes under The first build will thus be With that, this is no longer a draft. |
2 tasks
|
Good that RetroGradle is moving along👍. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the result of copying all the commits made on top of https://github.com/MinecraftForge/FernFlowerLegacy, converting those to patches, and applying them in the style of ForgeFlower.
All upstream patches are removed, and thus this should be considered a completely different product than the master branch; thus the branch this is PRed to uses a legacy- prefix.
This is Part 5 of the RetroGradle initiative.
Limitations
Being that this is forked from FernFlowerLegacy, it is limited to Java 9 features.
Therefore, this version of ForgeFlower cannot decompile any J10+ features, such as records, try-with-resources, enhanced switch, or any other syntax sugar related code.
However, it does not need to; the Minecraft 1.11 (and below) code it is designed for does not use any of these.
TODO