This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Open
Conversation
Added the function for finding the percentage of single visits by continent.
jonathancstroud
suggested changes
Oct 4, 2018
Contributor
jonathancstroud
left a comment
jonathancstroud
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please see the comments and make the requested changes, and I will approve.
explore_utils.py
Outdated
| number_of_people = train_df2[train_df2['geoNetwork.continent'] == con]['visitNumber'].count() | ||
| train_df3 = train_df2[train_df2['geoNetwork.continent'] == con]['visitNumber'] | ||
| number_of_single_visits = train_df3[train_df3 == 1].count() | ||
| print('Percentage of people visited for once in '+ con + ': '+(str)((number_of_single_visits/number_of_people)*100)) |
Contributor
There was a problem hiding this comment.
Instead of printing your results here, please call this function from explore.py and print the results there.
nikunj3107
approved these changes
Oct 6, 2018
Contributor
nikunj3107
left a comment
nikunj3107
left a comment
There was a problem hiding this comment.
Everything looks good after the changes!
sinankarabocu
requested review from
claban3,
mkbwang and
wesleytian
as code owners
Contributor
There was a problem hiding this comment.
Rather than returning a string, you should return a value and take care of printing in explore.py.
jonathancstroud
suggested changes
Oct 16, 2018
Contributor
jonathancstroud
left a comment
jonathancstroud
left a comment
There was a problem hiding this comment.
Please add calls to your functions to explore.py as well as print statements there to display the your results.
| return counts, means | ||
|
|
||
|
|
||
| def find_transaction_by_region(data): |
Contributor
There was a problem hiding this comment.
Is this function used anywhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the function for finding the percentage of single visits by continent.