Skip to content

Move input from add_datasets/rose-app.conf to rose-suite.conf#394

Open
NParsonsMO wants to merge 12 commits intomainfrom
393_move_input_from_app_to_suite
Open

Move input from add_datasets/rose-app.conf to rose-suite.conf#394
NParsonsMO wants to merge 12 commits intomainfrom
393_move_input_from_app_to_suite

Conversation

@NParsonsMO
Copy link
Collaborator

@NParsonsMO NParsonsMO commented Mar 3, 2026 •
edited by zmaalick
Loading

Closes #393.

PR creation checklist for the developer

  • The <issue_number> above ☝️ has been replaced with the issue number.
  • main has been selected as the base branch.
  • The feature branch name follows the format <issue_number>_<short_description_of_feature>.
  • The text of the PR title exactly matches with the text (not including the issue number) of the issue title.
  • Appropriate reviewers have been added to the PR (once it is ready for review).
  • The PR has been assigned to the developer(s).
  • The same labels as on the issue (except for the good first issue label) have been added to the PR.
  • The Climate Model Evaluation Workflow (CMEW) project has been added to the PR.
  • The appropriate milestone has been added to the PR.

Definition of Done for the developer

  • The change in this PR addresses the above issue / all acceptance criteria have been met.
  • The change in this PR follows the requirements in the wiki: Developer Guide (including copyrights).
  • The GitHub Actions workflow checks pass.
  • The tests run locally and pass (Note: the tests are not run by the GitHub Actions workflow, see wiki: Run the tests locally).
  • Updating the Rose metadata (select one of the following):
    • Rose metadata related to the change has been added or updated.
    • The change does not require Rose metadata to be added or updated.
  • Rendering the Rose metadata (select one of the following):
    • The Rose GUI shows the change as expected.
    • The change in this PR does not affect the Rose GUI.
  • Updating the tests (select one of the following):
    • Tests related to the change have been added or updated.
    • The change does not require tests to be added or updated.
  • Updating the user documentation (i.e. everything in the doc directory, including the Quick Start section; select one of the following):
    • The user documentation related to the change has been updated appropriately.
    • The change in this PR does not require the user documentation to be updated.
  • Rendering the user documentation (wiki: Build the documentation locally provides instructions; select one of the following):
    • The HTML pages show the change as expected.
    • The change in this PR does not affect the HTML pages.
  • Updating the API documentation (e.g. docstrings in Python modules; select one of the following):
    • The API documentation related to the change has been updated appropriately.
    • The change in this PR does not affect the API documentation.

PR creation checklist for the reviewer

  • The <issue_number> above ☝️ has been replaced with the issue number.
  • main has been selected as the base branch.
  • The feature branch name follows the format <issue_number>_<short_description_of_feature>.
  • The text of the PR title exactly matches with the text (not including the issue number) of the issue title.
  • Appropriate reviewers have been added to the PR (once it is ready for review).
  • The PR has been assigned to the developer(s).
  • The same labels as on the issue (except for the good first issue label) have been added to the PR.
  • The Climate Model Evaluation Workflow (CMEW) project has been added to the PR.
  • The appropriate milestone has been added to the PR.

Definition of Done for the reviewer

  • The change in this PR addresses the above issue / all acceptance criteria have been met.
  • The change in this PR follows the requirements in the wiki: Developer Guide (including copyrights).
  • The GitHub Actions workflow checks pass.
  • The tests run locally and pass (Note: the tests are not run by the GitHub Actions workflow, see wiki: Run the tests locally).
  • Updating the Rose metadata (select one of the following):
    • Rose metadata related to the change has been added or updated.
    • The change does not require Rose metadata to be added or updated.
  • Rendering the Rose metadata (select one of the following):
    • The Rose GUI shows the change as expected.
    • The change in this PR does not affect the Rose GUI.
  • Updating the tests (select one of the following):
    • Tests related to the change have been added or updated.
    • The change does not require tests to be added or updated.
  • Updating the user documentation (i.e. everything in the doc directory, including the Quick Start section; select one of the following):
    • The user documentation related to the change has been updated appropriately.
    • The change in this PR does not require the user documentation to be updated.
  • Rendering the user documentation (wiki: Build the documentation locally provides instructions; select one of the following):
    • The HTML pages show the change as expected.
    • The change in this PR does not affect the HTML pages.
  • Updating the API documentation (e.g. docstrings in Python modules; select one of the following):
    • The API documentation related to the change has been updated appropriately.
    • The change in this PR does not affect the API documentation.

Important

  • Remember to re-check the Definition of Done after making changes in response to a review.
  • The developer merges the PR.
  • Remember to use the format #<pull_request_number>: <pull_request_title> when writing the merge commit message for the pull request, so the pull request number is immediately visible on GitHub, regardless of the length of the pull request title.

@NParsonsMO NParsonsMO self-assigned this Mar 3, 2026
@NParsonsMO NParsonsMO added the configure Anything related to configuration label Mar 3, 2026
@NParsonsMO NParsonsMO marked this pull request as ready for review March 3, 2026 15:17
NParsonsMO
NParsonsMO commented Mar 3, 2026
View reviewed changes
doc/source/user_guide/workflow.rst
:Runs on:
Localhost
:Executes:
The ``add_datasets_to_sahre.py`` script from the |Rose| app.
Copy link
Collaborator Author

@NParsonsMO NParsonsMO Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was for a typo

@NParsonsMO NParsonsMO marked this pull request as draft March 3, 2026 16:36
@NParsonsMO
Copy link
Collaborator Author

NParsonsMO commented Mar 3, 2026

Implement the changes from

@NParsonsMO NParsonsMO marked this pull request as ready for review March 10, 2026 15:51
@zmaalick zmaalick self-requested a review March 11, 2026 09:05
NParsonsMO
NParsonsMO commented Mar 11, 2026
View reviewed changes
Copy link
Collaborator Author

@NParsonsMO NParsonsMO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add type=quoted to CMIP6 variant label

zmaalick
zmaalick approved these changes Mar 11, 2026
View reviewed changes
Copy link
Collaborator

@zmaalick zmaalick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checked passed and tests runs.

@mo-nikosbaltas mo-nikosbaltas self-requested a review March 13, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmaalick zmaalick zmaalick approved these changes

@mo-nikosbaltas mo-nikosbaltas Awaiting requested review from mo-nikosbaltas

At least 2 approving reviews are required to merge this pull request.

Assignees

@NParsonsMO NParsonsMO

Labels

configure Anything related to configuration

Projects

None yet

Milestone

v0.2.0 (multiple model runs)

Development

Successfully merging this pull request may close these issues.

Move input from add_datasets/rose-app.conf to rose-suite.conf

2 participants

@NParsonsMO @zmaalick