docs: Add missing documentation for accountType and selector options#780
Open
ruhil6789 wants to merge 3 commits intoMeshJS:mainfrom
Open
docs: Add missing documentation for accountType and selector options#780ruhil6789 wants to merge 3 commits intoMeshJS:mainfrom
ruhil6789 wants to merge 3 commits intoMeshJS:mainfrom
Conversation
- Document accountType option in MeshWallet initialization (payment/stake/drep) - Document selector option in MeshTxBuilder for coin selection customization - Update playground documentation to include selector option Fixes MeshJS#707
HinsonSIDAN
requested changes
Jan 13, 2026
HinsonSIDAN
requested changes
Jan 13, 2026
HinsonSIDAN
approved these changes
Jan 13, 2026
Member
HinsonSIDAN
left a comment
HinsonSIDAN
left a comment
There was a problem hiding this comment.
lgtm, thanks for fixing typo also
HinsonSIDAN
requested changes
Jan 13, 2026
Member
HinsonSIDAN
left a comment
HinsonSIDAN
left a comment
There was a problem hiding this comment.
Some minor changes before merging
Required Changes
| # | File | Issue | Fix |
|---|---|---|---|
| 1 | packages/mesh-wallet/src/mesh/index.ts:78 |
Incorrect networkId values - States "0 for mainnet, 1 for testnet" but Cardano uses mainnet=1, testnet=0 | Swap to "1 for mainnet, 0 for testnet" |
| 2 | apps/playground/.../initialize-txbuilder.tsx:50 |
Grammar error - "to initialized the lower level" | Change to "to initialize the lower level" |
Author
|
@HinsonSIDAN I’ve updated the code and pushed the required changes. Please have a look when you get a chance. |
HinsonSIDAN
approved these changes
Jan 13, 2026
Member
HinsonSIDAN
left a comment
HinsonSIDAN
left a comment
There was a problem hiding this comment.
lgtm, thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds missing documentation for two features identified in issue #707:
accountTypeoption in MeshWallet initializationselectoroption in MeshTxBuilder for coin selection customizationContext
Issue #707 identified several undocumented features. This PR addresses:
Changes
accountTypeparameter in MeshWallet class with examples for payment, stake, and drep account typesMeshTxBuilderOptionsinterface documenting all options includingselectorMeshTxBuilderconstructor with selector explanation and examplesinitialize-txbuilder.tsx) to include selector option in signature and options listCardanoSdkInputSelector(default) andLargestFirstInputSelectorIInputSelectorinterfaceAffected Components
@meshsdk/wallet@meshsdk/transactionType of Change
Related Issues
Fixes #707
Checklist
npm run test) (N/A - documentation only)npm run build) (N/A - documentation only)