-
Notifications
You must be signed in to change notification settings - Fork 0
CSS Bayan #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaxLisyanskiy
wants to merge
10
commits into
main
Choose a base branch
from
gh-pages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CSS Bayan #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
MaxLisyanskiy
commented
Mar 10, 2023
- Task: https://github.com/DrDiman/CSS-Bayan-task
- Screenshot:

- Deploy: https://maxlisyanskiy.github.io/cssBayan/cssBayan/index.html
- Done 10.03.2023 / deadline 13.03.2023
- Score: 140 / 140
- Everything is done from Repository requirements and how to submit task section (30)
- The accordion component is centered on the screen, with equal indents on the left and right (10)
- Icons, meme texts and meme images are exist (5)
- Placement of the meme, icons and meme text are the same as in provided example gif images (5)
- Smooth change (transition) of the meme images and icons is done (20)
- Responsive design with three breakpoints for mobile, tablet, and desktop exist. Accordion is displayed correctly at mobile 320x568, tablet 820x1180, desktop 1920×1080 (10)
- All visual effects when the cursor is hovering over the memes, when the mouse is down on a meme, and when a meme is selected are implemented (10)
- The entire row (text, icon, and meme image) clickable (5)
- Mobile first approach is used - cursor over the memes (hover) effect exists only for desktop devices (10)
- The cursor when it is hovering over the rows of the accordion is changing (5)
- Only flexible dimensions are used rem, em, %, vh, vw, fr and etc... The accordion is responsive (10)
- All blocks/parts of the accordion are in base flow of the dom elements. All elements are not positioned with top, left, right, bottom. float is not used. The value of position is only static (5)
- Pseudo-elements are not used (note: pseudo-classes are allowed) (5)
- Initially, the first meme should be expanded (5)
- Font size is changed at each device (mobile, tablet, desktop) (5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.