Skip to content

docs(mddocs): add en mddocs from docs_rework#183

Open
annamikhailovapsk wants to merge 2 commits intodevelopfrom
feature/mddocs-en-folder
Open

docs(mddocs): add en mddocs from docs_rework#183
annamikhailovapsk wants to merge 2 commits intodevelopfrom
feature/mddocs-en-folder

Conversation

@annamikhailovapsk
Copy link

Change Summary

Created en folder documentation with documents in markdown

Related issue number

[DOP-28349]

Checklist

  • [ x ] Commit message and PR title is comprehensive
  • [ x ] Keep the change as small as possible
  • [ x ] Unit and integration tests for the changes exist
  • [ x ] Tests pass on CI and coverage does not decrease
  • [ x ] Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • [ x ] My PR is ready to review.

@github-actions
Copy link

Coverage

Coverage Report •
FileStmtsMissBranchBrPartCoverMissing
TOTAL25282023088392% 
report-only-changed-files is enabled. No files were changed during this commit :)

@dolfinus dolfinus self-requested a review March 12, 2026 12:09
@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Mar 12, 2026
deactivate "Client"
@enduml
```
<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь и в dummy.md mermaid диаграмма закомментирована, в ldap.md нет


After successful auth, username is saved to backend database. It is then used for creating audit records for any object change, see `changed_by` field.

### WARNING
Copy link
Member

@dolfinus dolfinus Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может тут имеет смысл использовать admonition вместо заголовка?

Comment on lines +29 to +32
- you can search for user by `uid`, e.g. `(uid={login})` or `(sAMAccountName={login})`
- you can search for user by several attributes, e.g. `(|(uid={login})(mail={login}@domain.com))`
- you can filter for entries, like `(&(uid={login})(objectClass=person)`
- you can filter for users matching a specific group or some other condition, like `(&(uid={login})(memberOf=cn=MyPrettyGroup,ou=Groups,dc=mycompany,dc=com))`
Copy link
Member

@dolfinus dolfinus Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- you can search for user by `uid`, e.g. `(uid={login})` or `(sAMAccountName={login})`
- you can search for user by several attributes, e.g. `(|(uid={login})(mail={login}@domain.com))`
- you can filter for entries, like `(&(uid={login})(objectClass=person)`
- you can filter for users matching a specific group or some other condition, like `(&(uid={login})(memberOf=cn=MyPrettyGroup,ou=Groups,dc=mycompany,dc=com))`
- search for user by `uid`, e.g. `(uid={login})` or `(sAMAccountName={login})`
- search for user by several attributes, e.g. `(|(uid={login})(mail={login}@domain.com))`
- filter for entries, like `(&(uid={login})(objectClass=person)`
- filter for users matching a specific group or some other condition, like `(&(uid={login})(memberOf=cn=MyPrettyGroup,ou=Groups,dc=mycompany,dc=com))`

Это ведь делает AuthProvider, не пользователь, не совсем понятно кто есть you. Возможно это проблема в исходной доке

@@ -0,0 +1,3 @@
.logo {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пути должны быть вида mkdocs/ вместо mkdocs/en/

## Example metrics

```default
# Generated in CI
Copy link
Member

@dolfinus dolfinus Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Что-то странное, здесь и ниже по идее должен подставляться .prom файл, который CI наполняет примером в момент сборки доки


### `docker-compose.yml`

```default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Копировать docker-compose.yml не надо, нужно его подставлять и выделять нужные строки, которые важны для конкретного компонента


<!-- this page cannot be properly rendered in local environment, it should be build in CI first -->
<!--!DOCTYPE html>
<html lang="en">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не совсем понятно, зачем тут кусок html внутри .md, и почему он закомментирован

@@ -0,0 +1,5 @@
# 0.0.10 (2024-01-22) { #0.0.10 }
Copy link
Member

@dolfinus dolfinus Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Есть подозрение что якоря не могут содержать точки, и они должны выглядеть как version-0-0-10. Но это нужно проверить

Comment on lines +2 to +3
```{eval-rst}
.. towncrier-draft-entries:: |release| [UNRELEASED]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно временно это дропнуть, и позже перейти на интеграцию mkdocs с towncrier

Comment on lines +13 to +18
<!--
```{eval-rst}
.. autopydantic_model:: HWMHistoryResponseV1
:model-show-field-summary: false
```
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется эти закомментированные блоки нам не нужны, не?

```{eval-rst}
.. currentmodule:: horizon.commons.schemas.v1.user
``` -->
<!-- TODO: fix docstring extraction -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Проблема не исправилась?


## Base

### *class* horizon.commons.exceptions.base.ApplicationError
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Из docstring это не извлекается?

@enduml
```

```mermaid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mermaid пустой, он нужен?

@@ -0,0 +1,167 @@
# SPDX-FileCopyrightText: 2025-present MTS PJSC
Copy link
Member

@dolfinus dolfinus Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это кусок конфига для sphinx, он точно здесь нужен? Как и mkdocs/Makefile и mkdocs/make.bat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants