CNNT: dynamic positional embeddings to support variable input sizes#150
Open
SarthakJagota wants to merge 1 commit intoML4SCI:mainfrom
Open
CNNT: dynamic positional embeddings to support variable input sizes#150SarthakJagota wants to merge 1 commit intoML4SCI:mainfrom
SarthakJagota wants to merge 1 commit intoML4SCI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the hard-coded patch count used to initialize positional embeddings in the CNNT model and instead creates them dynamically based on the CNN output sequence length.
Changes
Compute patch sequence length from CNN feature maps
Create positional embeddings dynamically to avoid shape mismatches
Properly register positional embeddings so they are tracked by the optimizer
Maintain existing behavior for default input configurations
Motivation
The previous implementation assumed a fixed input resolution, which limited reuse across DeepLense tasks and could lead to runtime errors when image sizes change.
This update makes CNNT resolution-agnostic and improves model flexibility.
#149