Merged
Conversation
Why these changes are being introduced: The first round of GitHub Actions workflows included the dev and stage deployments, but not the production deployment. This addresses that gap. How this addresses that need: * Update the continuous-delivery documentation in the docs/ folder to describe the approach to production deployment * Create a new prod-deploy.yml workflow to handle the stage-to-prod container copy process that we use, but ensure that it copies both containers (GPU and CPU) and tags them correctly. Side effects: None.
Why these changes are being introduced: There is too much build churn in Dev1 for dependabot-triggered PRs, not only burning through too many minutes of GHA time but also introducing problems in the dev containers during active development. How this addresses that need: * Add a conditional to the jobs in dev-build to only run if the trigger is not dependabot Side effects: None.
ghukill
approved these changes
Jan 29, 2026
Collaborator
ghukill
left a comment
ghukill
left a comment
There was a problem hiding this comment.
Looks good! Will reach out when we finally tag a release.
| choose-runners: | ||
| choose-runners: | ||
| # This line adds a check for the user which is requesting the PR. As long as its not dependabot, we go ahead and run it. | ||
| if: ${{ github.triggering_actor != 'dependabot[bot]' }} |
Collaborator
There was a problem hiding this comment.
Thanks for the catch and add here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Up until now, there was no functional GHA workflow for deploying a container image to Prod-Workloads. This addresses that need by creating a working
prod-deploy.ymlGHA workflow. At the same time, this addresses the build churn fromdependabotthat should have been included in thedev-build.ymlworkflow right from the start; e.g., never run builds fordependabot-triggered PRs.How can a reviewer manually see the effects of these changes?
There is no way to manually see the effects of these changes. We will have to wait until this is merged to
mainand then tag a new release onmainto see if the build runs correctly.Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
Code review