Package / Actions Cleanup - Continuation of #435#436
Open
simmsa wants to merge 41 commits intoMHKiT-Software:developfrom
Open
Package / Actions Cleanup - Continuation of #435#436simmsa wants to merge 41 commits intoMHKiT-Software:developfrom
simmsa wants to merge 41 commits intoMHKiT-Software:developfrom
Conversation
There is a bug where something in requiring pyarrow that is likely related to pandas 3.0. Adding pyarrow as a dependency is a reasonable fix, but managing the pyarrow version should be handled by pandas and not mhkit. This pins pandas below 3.0 to see if pyarrow dependencies are caused by including >= 3.0 somewhere.
``` prepare-nonhindcast-cache The 'defaults' channel might have been added implicitly. If this is intentional, add 'defaults' to the 'channels' list. Otherwise, consider setting 'conda-remove-defaults' to 'true'. ```
Coveralls is down this morning: https://status.coveralls.io/ ``` Update - Outage will be extended for at least several more hours. To avoid further disruption to your CI workflows, we recommend employing the fail-on-error: false input option available with all official coveralls integrations. See: https://docs.coveralls.io/integrations#official-integrations. Feb 24, 2026 - 19:28 PST ``` This changes adds a switch to enable/disable coveralls failures. This should be set back to TRUE when coveralls is working again.
Xarray leverages netcdf and h5 libraries behind the scenes. Historically it is better for MHKiT to manage the versions for these libraries vs latest because of subtle breaking changes. This moves the deps into all because all data functions in mhkit support xarray output and thus require all the h5, nc libraries.
…n job coveralls@v2 needs curl, which is not in the python:3-slim container. The simplest solution is to just use the default ubuntu container spec.
All jobs should use the same conda settings. This sets global settings for conda channels and conda remove defaults settings in one place that is DRY and easy to configure
Contributor
Author
|
@akeeste and @jmcvey3 this is ready. Do any of you have a preference if we add this to #435 or keep this as a separate PR? Happy to do whatever makes sense. There are lots of small test/action errors, warnings, and nits that this fixes. Also coveralls is still down: https://status.coveralls.io/. This adds a flag to ignore coveralls upload errors but that has the potential to lead to false positives (tests fail, but old passing test badges are shown to the user). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation and refinement of #435
Highlights:
From #435
Dependencies
Module Dependencies
allConda and Conda-Forge Dependency Definitions
Actions
Linting
blackon files that have changedCoveralls
Error: Bad response: 530 error code: 1016per: https://status.coveralls.io/ and this implements the recommendedfail-on-error: falsefixWe can incorporate this into #435 if that makes sense. My main goal here is to understand what changes are necessary in #435