test: add tests for team_users and correct list_team_users_by count#3283
Open
laraujo7 wants to merge 1 commit intoLogflare:mainfrom
Open
test: add tests for team_users and correct list_team_users_by count#3283laraujo7 wants to merge 1 commit intoLogflare:mainfrom
laraujo7 wants to merge 1 commit intoLogflare:mainfrom
Conversation
laraujo7
force-pushed
the
la/team_users-tests
branch
from
866419d to
39d4075
Compare
nelsonmestevao
approved these changes
Mar 13, 2026
Ziinc
requested changes
Mar 16, 2026
|
|
||
| true -> | ||
| count = list_team_users_by(id: team_id) |> Enum.count() | ||
| count = list_team_users_by(team_id: team_id) |> Enum.count() |
Contributor
There was a problem hiding this comment.
Should cover this bugfix with a test.
Contributor
Author
There was a problem hiding this comment.
Yeap, will do so 💪
Contributor
Author
There was a problem hiding this comment.
Currently, the condition count < limit always evaluates to true because count is always 0, so a new team_user is always created. I’ve added a test to verify the behavior when the team has already reached the limit, so I believe this case is now covered. Let me know if you think we should handle it differently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.