Skip to content

Development #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LockedThread merged 2 commits into from
Mar 5, 2025
Merged

Development #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a79291
fix LD_LIBRARY_PATH
LockedThread Mar 5, 2025
9ab1a0e
Merge pull request #40 from LockedThread/release/1.6.3
LockedThread Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
FROM debian:bullseye as dependencies

Check warning on line 1 in Dockerfile

View workflow job for this annotation

GitHub Actions / release / build (linux/amd64)

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 1 in Dockerfile

View workflow job for this annotation

GitHub Actions / release / build (linux/arm64)

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
ARG PYTHON_VERSION=3.11.2

# Disable GUI prompts
ENV DEBIAN_FRONTEND noninteractive

Check warning on line 5 in Dockerfile

View workflow job for this annotation

GitHub Actions / release / build (linux/amd64)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 5 in Dockerfile

View workflow job for this annotation

GitHub Actions / release / build (linux/arm64)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/


RUN rm /var/lib/dpkg/info/libc-bin.*
Expand Down Expand Up @@ -49,7 +49,7 @@
RUN python3 -m pip install --upgrade pip

# Use git to clone gtsam and specific GTSAM version
FROM alpine/git:2.47.2 as gtsam-clone

Check warning on line 52 in Dockerfile

View workflow job for this annotation

GitHub Actions / release / build (linux/amd64)

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 52 in Dockerfile

View workflow job for this annotation

GitHub Actions / release / build (linux/arm64)

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

ARG GTSAM_VERSION=4.2.0
WORKDIR /usr/src/
Expand All @@ -61,7 +61,7 @@
git checkout ${GTSAM_VERSION}

# Create new stage called gtsam for GTSAM building
FROM dependencies as gtsam

Check warning on line 64 in Dockerfile

View workflow job for this annotation

GitHub Actions / release / build (linux/amd64)

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 64 in Dockerfile

View workflow job for this annotation

GitHub Actions / release / build (linux/arm64)

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

# Move gtsam data
COPY --from=gtsam-clone /usr/src/gtsam /usr/src/gtsam
Expand All @@ -69,7 +69,7 @@
WORKDIR /usr/src/gtsam/build

# Needed to link with GTSAM
RUN echo 'export LD_LIBRARY_PATH=/usr/local/lib:LD_LIBRARY_PATH' >> /root/.bashrc
RUN echo "export LD_LIBRARY_PATH=/usr/local/lib:\$LD_LIBRARY_PATH" >> /root/.bashrc

# Install python wrapper requirements
RUN python3 -m pip install -U -r /usr/src/gtsam/python/requirements.txt
Expand Down
Loading