Skip to content

Fix App Check: Container Path#1650

Merged
shuds13 merged 10 commits intoLibensemble:developfrom
ax3l:fix-app-check-container
Feb 6, 2026
Merged

Fix App Check: Container Path#1650
shuds13 merged 10 commits intoLibensemble:developfrom
ax3l:fix-app-check-container

Conversation

@ax3l
Copy link
Collaborator

@ax3l ax3l commented Jan 13, 2026

When using the precedent to run apps from container images, the executable is not available to check for the host side. This relaxes respective "early" checks to support this workflow.

X-ref: optimas-org/optimas#292

shuds13 and others added 4 commits July 2, 2025 10:54
When using the `precedent` to run apps from container images,
the executable is not available to check for the host side. This
relaxes respective "early" checks to support this workflow.
@ax3l ax3l force-pushed the fix-app-check-container branch from 4f5aa3a to fd3c441 Compare January 13, 2026 02:18
@ax3l
Copy link
Collaborator Author

ax3l commented Jan 13, 2026

@shuds13 the remaining test failure looks unrelated to this PR.

@shuds13
Copy link
Member

shuds13 commented Jan 13, 2026

Looks good, can this point to develop?

@ax3l ax3l changed the base branch from main to develop January 13, 2026 16:37
@ax3l
Copy link
Collaborator Author

ax3l commented Jan 13, 2026

Oh, sounds good. I changed the base of the PR now, just need to rebase later

@ax3l
Copy link
Collaborator Author

ax3l commented Feb 6, 2026

@shuds13 oh, I fear I need this PR as well. Can we finalize it together?

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.30%. Comparing base (d8c05c7) to head (0c9ed6f).
⚠️ Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1650   +/-   ##
========================================
  Coverage    78.29%   78.30%           
========================================
  Files           76       76           
  Lines         7580     7582    +2     
  Branches      1119     1120    +1     
========================================
+ Hits          5935     5937    +2     
  Misses        1460     1460           
  Partials       185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ax3l ax3l force-pushed the fix-app-check-container branch from 45dc07c to 0c9ed6f Compare February 6, 2026 22:25
@shuds13 shuds13 merged commit 4294a4d into Libensemble:develop Feb 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants