-
Notifications
You must be signed in to change notification settings - Fork 0
Develop #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #73
Conversation
Chore/add name override
WalkthroughThe changes add configuration enhancements to GitHub Actions workflows. The build.yml file introduces a new workflow input called 🚥 Pre-merge checks | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/gitops-update.yml:
- Around line 290-311: The workflow currently only falls back to the legacy
artifact when the download step fails, but a successful download with zero
matches leaves .gitops-tags empty and causes a silent no-op in the upd()
function; add an explicit artifact-presence check after the pattern download (in
the "List downloaded artifacts" step or a new step) that inspects .gitops-tags
for files and, if empty, triggers the fallback (e.g., set a step output/variable
or force that step to fail) so the existing fallback step (the "Fallback to
legacy artifact name" step) or an alternative action runs; locate references to
the download-pattern step id, the .gitops-tags path, and the upd() behavior ([[
-f "$file" ]] || return 0) when implementing the check.
Description
Type of Change
feat: New feature or workflowfix: Bug fixdocs: Documentation updaterefactor: Code refactoringperf: Performance improvementtest: Adding or updating testsci: CI/CD configuration changeschore: Maintenance tasksBREAKING CHANGE: Breaking change (requires major version bump)Affected Workflows
Changes Made
Breaking Changes
None / Describe breaking changes here
Testing
Checklist
Related Issues
Closes #
Related to #
Additional Notes