Skip to content

Conversation

@guimoreirar
Copy link
Member

@guimoreirar guimoreirar commented Jan 21, 2026

Description

Type of Change

  • feat: New feature or workflow
  • fix: Bug fix
  • docs: Documentation update
  • refactor: Code refactoring
  • perf: Performance improvement
  • test: Adding or updating tests
  • ci: CI/CD configuration changes
  • chore: Maintenance tasks
  • BREAKING CHANGE: Breaking change (requires major version bump)

Affected Workflows

  • GitOps Update
  • API Dog E2E Tests
  • PR Security Scan
  • Release Workflow
  • Other (specify): _______________

Changes Made

Breaking Changes

None / Describe breaking changes here

Testing

  • Tested locally
  • Tested in development environment
  • Tested with example repository: _______________
  • All existing workflows still work

Checklist

  • Code follows conventional commit format
  • Documentation updated (if applicable)
  • Examples updated (if applicable)
  • No hardcoded secrets or sensitive data
  • Backward compatible (or breaking changes documented)
  • Self-review completed
  • Comments added for complex logic

Related Issues

Closes #
Related to #

Additional Notes

@guimoreirar guimoreirar self-assigned this Jan 21, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Walkthrough

The changes add configuration enhancements to GitHub Actions workflows. The build.yml file introduces a new workflow input called app_name_overrides (string, default empty) that is passed to the LerianStudio/github-actions-changed-paths action to enable explicit app name mappings during monorepo path resolution. The gitops-update.yml file adds artifact download logic that first attempts to download artifacts using a pattern-based approach, with a fallback to the legacy artifact name if the initial download fails, and includes a step to list downloaded artifacts for visibility.

🚥 Pre-merge checks | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely unfilled, containing only the template structure with no actual content, no type of change marked, no affected workflows listed, and no explanation of the changes or testing performed. Fill in all required sections: provide a description of changes, mark the CI/CD type of change, list affected workflows (GitOps Update, Build workflow), describe changes made, confirm testing, and update the checklist items.
Title check ❓ Inconclusive The title 'Develop' is vague and non-descriptive, failing to communicate the actual changes made in the PR (workflow enhancements for app name overrides and artifact handling). Replace the generic title with a descriptive summary of the main change, such as 'Add app name override support and improve artifact handling in workflows' or reference the primary feature being added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/gitops-update.yml:
- Around line 290-311: The workflow currently only falls back to the legacy
artifact when the download step fails, but a successful download with zero
matches leaves .gitops-tags empty and causes a silent no-op in the upd()
function; add an explicit artifact-presence check after the pattern download (in
the "List downloaded artifacts" step or a new step) that inspects .gitops-tags
for files and, if empty, triggers the fallback (e.g., set a step output/variable
or force that step to fail) so the existing fallback step (the "Fallback to
legacy artifact name" step) or an alternative action runs; locate references to
the download-pattern step id, the .gitops-tags path, and the upd() behavior ([[
-f "$file" ]] || return 0) when implementing the check.

@guimoreirar guimoreirar merged commit 161bd39 into main Jan 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant