Skip to content

chore: update nix flake #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kathund wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update nix flake #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
packages = rec {
default = pkgs.rustPlatform.buildRustPackage {
pname = "spotatui";
version = "0.36.3-debug.1";
src = ./.;
version = "0.37.2";
Copy link
Owner

@LargeModGames LargeModGames Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe deriving the version from Cargo.toml is better then hardcoding the version in
version = (builtins.fromTOML (builtins.readFile ./Cargo.toml)).package.version

Im not sure if that is the correct syntax but something like that

Copy link
Author

@Kathund Kathund Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that probably is the correct as I overlooked the version (I just aligned it and didn't give much thought)
Since this is building form source personally it would make more sense to be {version}-{shortCommitHash}
This version "doesn't matter" as it's only really shown when the project is building

image

Since i have the version set to 0.0.0 that's the version that shows up during the compile. If you look at it and watch for when cargo get's to spotatui it still is loading 0.37.2 anyways

Id love to know what you think on this and what the "best approach" would be

Copy link
Author

@Kathund Kathund Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to add a photo of what the version I proposed looked liked so here that is now.

image

dirty isn't always going to be a thing and probably won't be as it's only showing up because I have changes in my git thus making it dirty

src = self;

cargoLock = {
lockFile = ./Cargo.lock;
Expand Down
Loading