Make CSP error logging validation more robust #2868
+14
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@labkey-tchad the suite passed after this test update. I am pretty confident this was an intermittent problem, but it failed twice in the FB before this change. |
labkey-tchad
approved these changes
Feb 3, 2026
Comment on lines
+24
to
+26
| // Add something unique to make sure log de-duping doesn't suppress the logging. Otherwise, running the test multiple | ||
| // times against the same server won't actually log the CSP error after the first hit | ||
| private static final String PROJECT_NAME = TRICKY_CHARACTERS_FOR_PROJECT_NAMES + "WikiCspTest" + System.currentTimeMillis(); |
Member
There was a problem hiding this comment.
We disable deduping in other tests by enabling debug logging for the CSP warning endpoint.
You can do so by calling CspConfigHelper.debugCspWarnings(); somewhere in the test setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
WikiCspTest has been failing in a feature branch because the error is logged a little later than expected.
https://teamcity.labkey.org/buildConfiguration/LabKey_2511Release_Community_ModuleSuites_WikiSqlserver/3826615
Related Pull Requests
Changes