include non-user editable columns in details view#812
Draft
labkey-kevink wants to merge 10 commits intodevelopfrom
Draft
include non-user editable columns in details view#812labkey-kevink wants to merge 10 commits intodevelopfrom
labkey-kevink wants to merge 10 commits intodevelopfrom
Conversation
Contributor
labkey-kevink
commented
Feb 6, 2020
labkey-kevink
commented
- include non-user editable columns details view by default
- infer column 'showInDetailsView' unless explicitly set
- validate queries checks for QueryView without detailsURL with showDetailsColumn=true
- infer column 'showInDetailsView' unless explicitly set
labkey-jeckels
requested changes
Feb 8, 2020
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
Maybe fine as-is, but a couple of questions.
| */ | ||
| public abstract class ColumnRenderPropertiesImpl implements ColumnRenderProperties | ||
| { | ||
| protected static final Set<String> NON_EDITABLE_COL_NAMES = new CaseInsensitiveHashSet( |
Contributor
There was a problem hiding this comment.
Let's wrap this in a Collections.unmodifiableSet(). It should preserve the case-insensitive semantics, but I've heard that immutability is good...
| protected boolean isColumnIncluded(ColumnInfo col) | ||
| { | ||
| return col.isShownInUpdateView(); | ||
| return col.isUserEditable() && col.isShownInUpdateView(); |
Contributor
There was a problem hiding this comment.
Do we need this check? I feel like there are a few cases where we want to show a read-only view of some columns, but I can't conjure up a concrete example either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.