Skip to content

Encapsulate all mutable CSP filter settings in a single object#7391

Open
labkey-adam wants to merge 1 commit intodevelopfrom
fb_atomic_csp_settings
Open

Encapsulate all mutable CSP filter settings in a single object#7391
labkey-adam wants to merge 1 commit intodevelopfrom
fb_atomic_csp_settings

Conversation

@labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Feb 4, 2026

Rationale

No functional change, this merely groups four per-CSP-filter settings into a single CspSettings object to encapsulate the logic around these settings and set them atomically. This reduces the synchronization required and prevents other threads from seeing a mix of old and new values.

Related Pull Requests

Tasks 📍

  • Manual Testing
    • Switch base server URL from http: to https: and back
    • Add and remove allowed external resource hosts
    • Turn the "Disable enforce Content Security Policy" experimental feature on and off
    • After each transition, ensure that the CSP and Reporting-Endpoints are as expected. No exceptions or errors in the log.

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have time to test yet.

@labkey-adam labkey-adam self-assigned this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants