Encapsulate all mutable CSP filter settings in a single object#7391
Open
labkey-adam wants to merge 1 commit intodevelopfrom
Open
Encapsulate all mutable CSP filter settings in a single object#7391labkey-adam wants to merge 1 commit intodevelopfrom
labkey-adam wants to merge 1 commit intodevelopfrom
Conversation
labkey-jeckels
approved these changes
Feb 5, 2026
Contributor
labkey-jeckels
left a comment
There was a problem hiding this comment.
I didn't have time to test yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
No functional change, this merely groups four per-CSP-filter settings into a single CspSettings object to encapsulate the logic around these settings and set them atomically. This reduces the synchronization required and prevents other threads from seeing a mix of old and new values.
Related Pull Requests
Tasks 📍