Switch from vcpkg manifest mode to classic mode#323
Open
gpx1000 wants to merge 6 commits intoKhronosGroup:mainfrom
Open
Switch from vcpkg manifest mode to classic mode#323gpx1000 wants to merge 6 commits intoKhronosGroup:mainfrom
gpx1000 wants to merge 6 commits intoKhronosGroup:mainfrom
Conversation
…mode by default on Windows Remove vcpkg.json manifest file and update installation scripts to use classic mode with explicit package list. Add CMake configuration to disable manifest mode by default on Windows to ensure compatibility with all vcpkg installations, including standalone packages and Visual Studio which may not have git or baseline support.
…-platform compatibility Move FindPackageHandleStandardArgs call after FetchContent fallback to ensure KTX_FOUND is properly set when fetching from GitHub. Remove premature error messages and debug output, and restructure target creation to work correctly with both system-installed and fetched KTX libraries.
…x classic mode installation Change package name to "simple-engine" and add platform specifiers to all dependencies. Update install script to use temporary manifest root directory for proper vcpkg classic mode operation, preventing manifest mode conflicts.
Add openal-soft to vcpkg.json dependencies. Update Windows install script to use temporary manifest root directory to prevent manifest mode conflicts when running vcpkg in classic mode.
…Make module path Try to find packages using CONFIG mode first (e.g., from vcpkg) before falling back to pkg-config or manual search. Create alias targets when needed to ensure compatibility. Change CMAKE_MODULE_PATH from APPEND to PREPEND to prioritize custom find modules. Downgrade KTX version to v4.3.1 for stability. Remove trailing whitespace.
…ule path handling Add platform specifiers to all vcpkg dependencies and enable vulkan feature for ktx. Move CMAKE_MODULE_PATH configuration before project() call to ensure custom find modules are prioritized. Update all Find modules to use _find_package when available for better vcpkg integration. Add vcpkg CONFIG mode support to Findstb.cmake. Remove trailing whitespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and disable manifest mode by default on Windows
Remove vcpkg.json manifest file and update installation scripts to use classic mode with explicit package list. Add CMake configuration to disable manifest mode by default on Windows to ensure compatibility with all vcpkg installations, including standalone packages and Visual Studio which may not have git or baseline support.