Add tensor_image_aliasing and postprocessing_with_vgf samples#1476
Open
matthewsloyanARM wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Add tensor_image_aliasing and postprocessing_with_vgf samples#1476matthewsloyanARM wants to merge 1 commit intoKhronosGroup:mainfrom
matthewsloyanARM wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
Signed-off-by: Matthew Sloyan <matthew.sloyan@arm.com>
Contributor
|
I see build errors with this change: |
Collaborator
|
Looks like this is caused by one of the new third party dependencies. I see two new ones in there:
Adding new submodules will require people that already cloned the repo to update these submodules, or else they'll be empty. Not sure if that's also the cause for the CI failures. In light of the samples already having serious issues with build times and complexity, I'm not sure if we want to add in even more dependencies (we're already shy of 20 submodules). Are these really required for this sample? |
Collaborator
|
Aside from that, the sample works fine for me on Windows with an Nvidia RTX4070 using the latest ML emulation layer (0.8.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, new sample or fixed issue. Please also include relevant motivation and context.
Please read the contribution guidelines
Fixes #
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: