Fix shader timestamp churn on checked-in shaders#1468
Open
gpx1000 wants to merge 2 commits intoKhronosGroup:mainfrom
Open
Fix shader timestamp churn on checked-in shaders#1468gpx1000 wants to merge 2 commits intoKhronosGroup:mainfrom
gpx1000 wants to merge 2 commits intoKhronosGroup:mainfrom
Conversation
… tree modifications Use `copy_if_different` instead of `copy` to prevent timestamp churn on checked-in shader binaries. Change `MAIN_DEPENDENCY` to `DEPENDS` and add `VERBATIM` to custom commands for HLSL, Slang, GLSL, and SPIR-V assembly shader compilation.
gary-sweet
approved these changes
Jan 12, 2026
asuessenbach
approved these changes
Jan 14, 2026
Collaborator
|
I'm not quite sure I understand what this is supposed t do. I still see builds for HLSL/GLSL/Slang shaders anytime I build the project, even if none of them have changed. Tested on MSVC2022. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize shader build system to avoid unnecessary rebuilds and source tree modifications
Use
copy_if_differentinstead ofcopyto prevent timestamp churn on checked-in shader binaries. ChangeMAIN_DEPENDENCYtoDEPENDSand addVERBATIMto custom commands for HLSL, Slang, GLSL, and SPIR-V assembly shader compilation.This is part of my make the build system better work. This fixes the issue we have called out for it so I'm breaking this change out of the overall change that I'm working on for cmake to improve our build speed on all platforms.
Fixes #1248
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: