Guard branching plane computation against zero-norm vectors#1
Draft
Guard branching plane computation against zero-norm vectors#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
get_branching_plane_vectorsand raise aValueErrorwith a helpful message when eitherg_aborh_abhas (near) zero norm.g_normandh_norm) when scalingh_abtog_abto avoid repeated recomputation and make the intent clearer.test_get_branching_plane_vectors_raises_on_zero_norm_inputsintests/test_real_data.pyto lock the behavior for degenerate inputs.Testing
pytest -qin the default environment initially failed during collection withModuleNotFoundError: No module named 'conezen'(import-path/install ergonomics issue).python -m pip install -e .failed in this environment due to inability to fetch build dependencysetuptools>=61.0(network/proxy restriction).PYTHONPATH=src pytest -q(the project test pattern used in CI) succeeded with4 passedincluding the new regression test.Codex Task