Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
what happens if the school isn't found in the csv file? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprint
Issue #49 : Geocoding School Names
Who worked on this sprint?
Zander, Steven, and Hansini
Features Implemented
New files created
src/lib/geocoding.ts
Existing files modified
src/lib/schema.ts
Acceptance Criteria
Testing: how did you test?
We tested by creating a new branch in neon and modifying the existing schools table so that we can upload test data to see if it works as intended. There are some scenarios in which it did not work, and in those scenarios it prints out the error so it can be manually fixed.
Features Not Implemented/Incomplete
As of right now, the .env for the branch is using the neon db branch, not the main one. We also didn't get to test as much as we wanted to, so we apologize if there are edge cases that fail. Just let us know and we can go back and fix those.
Screenshots:
N/A -- Backend
Tag Dan and Shayne
@danglorioso @shaynesidman