-
Notifications
You must be signed in to change notification settings - Fork 1
Plausability check #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Please test this carefully! |
Member
|
Should I get the last one as well? Some time-entries do not have any workpackages assigned
cloud-storage connector => test 2026-02-05T09:48:00-2026-02-05T09:49:00. Provide a WP number to be assigned to this time-entry (Enter to skip): 42098
? ⚠️ Found WP ' UI/UX imrovements: The search results won't scroll all the way down while using keyboard' in the project 'Stream Nextcloud app "OpenProject Integration"'. This project is none of your favorite projects! Do you really want to use a WP from a not-favorite project?: y
? ⚠️ Found WP ' UI/UX imrovements: The search results won't scroll all the way down while using keyboard' in the project 'Stream Nextcloud app "OpenProject Integration"'. This WP is not assigned to you but to 'Nabin Ale'! Do you really want to use a WP that is not assigned to you?: y
? WP: 42098. Subject: UI/UX imrovements: The search results won't scroll all the way down while using keyboard. Update t-metric entry?? [y/N] y |
Member
Member
Author
yes, that is the last confirmation, that was there already before |
saw-jan
approved these changes
Feb 5, 2026
Member
Author
|
@saw-jan I've adjusted the table size calculation and made the warnings be two-liners. Now the long WP names should be cropped |
Member
saw-jan
approved these changes
Feb 5, 2026
Member
|
LGTM 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


with this PR we adding some extra checks to make sure that the data transferred to OpenProject is correct.
There are 3 checks that are done:
openproject.teamin~/.OpenProjectTmetricIntegration.yaml(only one team is currently supported)The checks are run
check tmetric? ⚠️ Found WP 'my WP' in the project 'some project'. This WP is not assigned to you but to 'Artur Neumann'! Do you really want to use a WP that is not assigned to you?? [y/N]ythe time is assigned to this WPna new WP ID can be entereddiffthe diff-table has a new
WARNINGScolumn, listing all possible issues of the WP in OP