Open
Conversation
Owner
|
You raised a good point. I've noticed that the old logic for loading and reading state in the original llama-cpp-python has deviated from the way llama.cpp operates. I'll probably add this to my to-do list to refactor this part of the logic. You could also add a null check on the score array before it's called. |
Author
|
Unfortunately, (since I'm only used it to create embedding), I have not noticed that self.scores was used in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that
self.scoresonly changed whenself._logits_all == True, so only allocate it whenself._logits_all == True