Skip to content

Use new lint/test docker image in CI, lint codebase#87

Merged
seth-shaw-asu merged 3 commits into3.xfrom
lint-test
Feb 9, 2026
Merged

Use new lint/test docker image in CI, lint codebase#87
seth-shaw-asu merged 3 commits into3.xfrom
lint-test

Conversation

@joecorall
Copy link
Member

@joecorall joecorall commented Feb 5, 2026

GitHub Issue: Relates to Islandora/islandora#1095 Islandora/islandora#1096

What does this Pull Request do?

Replace the CI test GitHub Actions to instead of performing a drupal site install in the runner, use a docker image.

Also fixed a bug the tests surfaced for Drupal 10.x 4c90dad

that would throw

PHPUnit\Framework\Error\Warning thrown while calling __toString on a Drupal\Core\StringTranslation\TranslatableMarkup object in /var/www/drupal/web/core/lib/Drupal/Component/Render/FormattableMarkup.php on line 247: Placeholders must begin with one of the following "@", ":" or "%", invalid placeholder ( @bundle_name) with string: "Can't generate JSON-LD Context without at least one rdf:type for Entity type @entity_type, Bundle @bundle_name combo."

/var/www/drupal/web/core/lib/Drupal/Component/Utility/ToStringTrait.php:20
/var/www/drupal/web/modules/contrib/jsonld/src/ContextGenerator/JsonldContextGenerator.php:176

How should this be tested?

GitHub Actions pass all green

@joecorall joecorall marked this pull request as ready for review February 5, 2026 12:41
@joecorall joecorall requested a review from a team February 5, 2026 12:41
@seth-shaw-asu seth-shaw-asu merged commit 4f02e4e into 3.x Feb 9, 2026
8 checks passed
@seth-shaw-asu seth-shaw-asu deleted the lint-test branch February 9, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments