Skip to content

Enhance event handling with shared options#24

Merged
IsaacDSC merged 3 commits intomainfrom
enhancement/shared-opts-on-create-consumer
Feb 18, 2026
Merged

Enhance event handling with shared options#24
IsaacDSC merged 3 commits intomainfrom
enhancement/shared-opts-on-create-consumer

Conversation

@IsaacDSC
Copy link
Owner

Introduce shared options for event consumers, improving event handling and structure. Update related database schemas and data models to accommodate these changes. Adjust tests to reflect the new structure and ensure compatibility.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@IsaacDSC IsaacDSC requested a review from Copilot February 18, 2026 14:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

internal/wtrhandler/external_handle_http_test.go:65

  • The mock Event returned in this test case doesn't include an Option field, which means it will have a zero-value Opt struct. When event.Option.ToAsynqOptions() is called in the handler (line 90 of external_handle_http.go), it will return an empty slice of options. While this might work, it doesn't match real-world scenarios where events should have valid Option configurations. Consider adding a valid Option field to the mock Event to make the test more realistic and catch potential validation issues.
				s.EXPECT().GetEvent(gomock.Any(), "user.created").Return(domain.Event{
					Name: "user.created",
					Type: domain.EventTypeInternal,
					Consumers: []domain.Consumer{{
						ServiceName: "test-service",
						Host:        "http://localhost:8080",
						Path:        "/webhook",
					}},
				}, nil).Times(1)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

IsaacDSC and others added 2 commits February 18, 2026 12:10
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@IsaacDSC IsaacDSC merged commit 764af63 into main Feb 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants