Enhance event handling with shared options#24
Merged
Conversation
…ating related structures
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (1)
internal/wtrhandler/external_handle_http_test.go:65
- The mock Event returned in this test case doesn't include an Option field, which means it will have a zero-value Opt struct. When event.Option.ToAsynqOptions() is called in the handler (line 90 of external_handle_http.go), it will return an empty slice of options. While this might work, it doesn't match real-world scenarios where events should have valid Option configurations. Consider adding a valid Option field to the mock Event to make the test more realistic and catch potential validation issues.
s.EXPECT().GetEvent(gomock.Any(), "user.created").Return(domain.Event{
Name: "user.created",
Type: domain.EventTypeInternal,
Consumers: []domain.Consumer{{
ServiceName: "test-service",
Host: "http://localhost:8080",
Path: "/webhook",
}},
}, nil).Times(1)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce shared options for event consumers, improving event handling and structure. Update related database schemas and data models to accommodate these changes. Adjust tests to reflect the new structure and ensure compatibility.