Open
Conversation
…undef` rather than 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix findPoint function to handle is90or270 properly by checking for undef rather than 0
Existing behavior does not handle right-angles in beamChain correctly.
This was fixed previously, but there may have been regression with a change of OpenSCAD treating '0' as falsy before, and not now, However, I cannot confirm this.
The code snippit below used to cause the following error:
WARNING: cos() parameter could not be converted: argument 0: expected number, found string ("error") in file <Round-Anything/polyround.scad>, line 687The above code now (correctly) creates the following model:
