Merged
Conversation
Collaborator
|
I didn't find time to look through this yet. Is it super urgent or can we try fix the other PR first? |
Contributor
Author
This currently only affects OUS. It is urgent for us since it is a bug. But I have fixed it locally in our side. So I think we could deal it before next newer version of PRONTO published. :) |
Collaborator
|
yes, I thought we do it directly after we have fixed the other PR 👍 |
marrip
reviewed
Feb 6, 2026
marrip
reviewed
Feb 6, 2026
marrip
reviewed
Feb 6, 2026
Collaborator
marrip
left a comment
marrip
left a comment
There was a problem hiding this comment.
I have a question about how you handle gender assignment and would suggest to use a format string. Other than that, I think this looks good 👍
Co-authored-by: Martin Rippin <74295098+marrip@users.noreply.github.com>
marrip
approved these changes
Feb 12, 2026
Collaborator
marrip
left a comment
marrip
left a comment
There was a problem hiding this comment.
I am content, looking good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix: PRONTO will crash when the "Gender" information is missing in MTF file.