feat: support way of providing clients through a callable to simplify runtime modification of clients dict#63
Open
MelchiorKokernoot wants to merge 1 commit intoIdentityPython:masterfrom
Conversation
…ntime modification of dict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During development on our software using this package, we encountered the need to alter the clients dict on runtime. Altough possible to do this through external (outside of the package) means, we reckoned this might be a feature that could be easy to implement in the package.
I have written the clients dict parameter to an internal
_clientsdict, which is now accessed through an annotated prop. When accessing the prop a check is done if the actual value is callable and is called instead of just directly accessing the dict.Tests have been added