chore: implememted react-query for events page#100
Open
Prajwalprakash3722 wants to merge 3 commits intomasterfrom
Open
chore: implememted react-query for events page#100Prajwalprakash3722 wants to merge 3 commits intomasterfrom
Prajwalprakash3722 wants to merge 3 commits intomasterfrom
Conversation
chrisvrose
reviewed
Mar 29, 2023
Member
chrisvrose
left a comment
There was a problem hiding this comment.
Looks good. I would approve but since it is a POC I am not putting it for merge yet and I am not aware of further discussions.
Co-authored-by: Atreya Bain <christophervrose@gmail.com>
Member
Author
|
Yes, I agree with you @chrisvrose, this is still a POC, however we can improve many things, perhaps @dragonfist453, @MayurSChittaragi can initiate the discussion. |
MayurSChittaragi
approved these changes
Apr 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useQueryhook to fetch the events data from the server using axios.I believe this updated code is a more efficient and maintainable solution compared to the previous
useEffect()implementation. Please review and merge the changes if they meet your requirements. You can find more details about the changes and the reference link to the original issue in the PR.Reference : #99
Requesting a review from the OG author(s) of the code as they are the ones who wrote it.
Please Note: This implementation is more like a prototype