Skip to content

Conversation

@jaredwray
Copy link
Contributor

@jaredwray jaredwray commented Feb 10, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: upgrading react and other modules to latest

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jaredwray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine maintenance task by upgrading several core dependencies to their latest stable versions. The primary updates include React and ReactDOM, along with their associated TypeScript type definitions and the happy-dom testing environment. These upgrades ensure the project benefits from the latest features, performance improvements, and security patches provided by these libraries, maintaining the project's health and compatibility with modern development practices.

Highlights

  • React and ReactDOM Upgrade: Upgraded React and ReactDOM to their latest patch version, 19.2.4, ensuring the project benefits from recent fixes and minor improvements.
  • TypeScript Type Definitions Update: Updated TypeScript type definitions for Node.js (@types/node) and React (@types/react) to their latest versions, enhancing type safety and compatibility.
  • Happy DOM Upgrade: Upgraded the happy-dom testing environment to version 20.5.0, which may include performance enhancements or bug fixes for DOM simulation.
  • Dependency Lockfile Synchronization: Synchronized the pnpm-lock.yaml file to reflect all updated dependency versions and their transitive dependencies, including the addition of entities@4.5.0 and consolidation of undici-types.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • package.json
    • Updated @types/node from ^25.0.9 to ^25.2.2
    • Updated @types/react from ^19.2.8 to ^19.2.13
    • Updated happy-dom from ^20.3.1 to ^20.5.0
    • Updated react from ^19.2.3 to ^19.2.4
    • Updated react-dom from ^19.2.3 to ^19.2.4
  • pnpm-lock.yaml
    • Updated various package resolutions to reflect new versions of @types/node, @types/react, happy-dom, react, and react-dom
    • Removed undici-types@6.21.0 and consolidated usage to undici-types@7.16.0
    • Added entities@4.5.0 as a new transitive dependency
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (495319b) to head (3759dbe).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           19        19           
  Branches         1         1           
=========================================
  Hits            19        19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit b66d041 into main Feb 10, 2026
10 checks passed
@jaredwray jaredwray deleted the chore-upgrading-react-and-other-modules-to-latest branch February 10, 2026 17:32
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades several development dependencies to their latest versions, including React and related packages. The version bumps in package.json and the resulting changes in pnpm-lock.yaml are correct. However, I've identified a potential issue with how react-dom is declared. It's currently a devDependency but should be a peerDependency for a React library like this, especially since it's externalized in the build configuration. I've left a specific comment with a recommendation to fix this to avoid potential issues for consumers of your SDK.

"react-dom": "^19.2.3",
"happy-dom": "^20.5.0",
"react": "^19.2.4",
"react-dom": "^19.2.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

react-dom should be a peerDependency, not a devDependency. Since this is a library and react-dom is externalized in your build (tsup.config.ts), consumers need to provide it. Declaring it as a peer dependency prevents version mismatches and runtime errors.

Please move it to peerDependencies with a compatible version range, similar to react:

"peerDependencies": {
  "react": "^18.0.0 || ^19.0.0",
  "react-dom": "^18.0.0 || ^19.0.0"
}

And remove it from devDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant